Skip to content

No use for metadata_client.PatchStatus #1514

Closed
@furkhat

Description

@furkhat

Metadata client's PatchStatus receives client.Object that must be of *metav1.PartialObjectMetadata type which seems useless because PartialObjectMetadata doesn't have fields that describe status.

Here
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/metadata_client.go#{L169:L172} - exits with error if type isn't *metav1.PartialObjectMetadata
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/client.go#L259-L260 - calls metadata_client.PatchStatus only if type is *metav1.PartialObjectMetadata

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions