Skip to content

Release new version (v0.9.0?) with v0.21.0 client-go support #1473

Closed
@howardjohn

Description

@howardjohn

With v0.8.3 and v0.21.0 client-go, I get the following error

../../../pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/metrics/client_go_adapter.go:135:3: cannot use &resultAdapter{...} (type *resultAdapter) as type metrics.ResultMetric in field value:
        *resultAdapter does not implement metrics.ResultMetric (wrong type for Increment method)
                have Increment(string, string, string)
                want Increment(context.Context, string, string, string)

This is already fixed on master branch, but its not ideal to deploy a version without a tag. So it would be great to release a new tag so we can pick up Kubernetes 1.21 libraries

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions