controllerutil.CreateOrPatch doesn't update not empty Status fields if Spec fields are specified

[dmvolod]

If we would like to patch custom resource with some Spec fields and Status which are not empty, the controllerutil.CreateOrPatch patches Spec only fields, but any Status keep unchanged,
result returns OperationResultUpdatedStatus which means that both Spec and Status where updated
The reason why this happens is that the original Status of the object is returned when the" Patch "procedure is exited and, as a result, no Status fields are updated

[dmvolod]

Reproducer created. See linked commit

[coderanger]

Do you have the status subresource enabled? If so, you need to specifically use a status writer call.

[dmvolod]

@coderanger are you mean // +kubebuilder:subresource:status instruction? Yes, we have it.
What does status writer call means. This function works fine with Spec and non Status.Condtions updates

[coderanger]

Turning on that subresource means that all changes to fields under .status will be blocked from calls to client.Update(). You must separately use client.Status().Update() (which in turn only applies changes under .status). This is the purpose of the status subresource. If you don't want that behavior, don't enable it :)

[dmvolod]

@coderanger please pay attention that,

• we are using and talking about controller-runtime library function called controllerutil.CreateOrPatch and it implementing with separate resource Spec and Status Patch

  controller-runtime/pkg/controller/controllerutil/controllerutil.go

  Line 234 in 5fd8414

  func CreateOrPatch(ctx context.Context, c client.Client, obj client.Object, f MutateFn) (OperationResult, error) {

• first (empty Status field) are works fine. Both Status and Spec fields are updated
• This case doesn't work for the next controllerutil.CreateOrPatch calls even if only Status fields are updated