Shell check errors on scripts in hack folder #1260
Description
I found that shell check complain about:
- SC2086: Double quote to prevent globbing and word splitting.
- SC2034: envtest_root_dir appears unused. Verify use (or export if used externally).
- SC1090: Can't follow non-constant source. Use a directive to specify location.
- SC2046: Quote this to prevent word splitting.
- SC2128: Expanding an array without an index only gives the first element.
- SC2155: Declare and assign separately to avoid masking return values.
From my opinion the pre-commit project can catch such errors when someone will try to commit new shell script to this repository.