Skip to content

Commit

Permalink
Merge pull request #2789 from chrischdi/pr-manager-fix-godoc-add-metrics
Browse files Browse the repository at this point in the history
📖 manager: fix godoc about http servers
  • Loading branch information
k8s-ci-robot authored Apr 19, 2024
2 parents e2191b5 + 5871905 commit a92b961
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/manager/internal.go
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) {
}
}

// First start any HTTP servers, which includes health probes and profiling, if enabled.
// First start any HTTP servers, which includes health probes, metrics and profiling if enabled.
//
// WARNING: HTTPServers includes the health probes, which MUST start before any cache is populated, otherwise
// it would block conversion webhooks to be ready for serving which make the cache never get ready.
Expand Down

0 comments on commit a92b961

Please sign in to comment.