Merge pull request #2329 from sbueringer/pr-fix-deprecation-node

🌱 Fix webhook options deprecation notes
kubernetes-sigs · May 17, 2023 · 124fac6 · 124fac6
2 parents 76865b2 + 9669e9e
commit 124fac6
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pkg/manager/manager.go b/pkg/manager/manager.go
@@ -33,6 +33,7 @@ import (
 	"k8s.io/client-go/tools/leaderelection/resourcelock"
 	"k8s.io/client-go/tools/record"
 	"k8s.io/utils/pointer"
+
 	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/cluster"
@@ -281,12 +282,12 @@ type Options struct {
 	// Port is the port that the webhook server serves at.
 	// It is used to set webhook.Server.Port if WebhookServer is not set.
 	//
-	// Deprecated: Use WebhookServer.Port instead.
+	// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
 	Port int
 	// Host is the hostname that the webhook server binds to.
 	// It is used to set webhook.Server.Host if WebhookServer is not set.
 	//
-	// Deprecated: Use WebhookServer.Host instead.
+	// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
 	Host string
 
 	// CertDir is the directory that contains the server key and certificate.
@@ -295,12 +296,12 @@ type Options struct {
 	// must be named tls.key and tls.crt, respectively.
 	// It is used to set webhook.Server.CertDir if WebhookServer is not set.
 	//
-	// Deprecated: Use WebhookServer.CertDir instead.
+	// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
 	CertDir string
 
 	// TLSOpts is used to allow configuring the TLS config used for the webhook server.
 	//
-	// Deprecated: Use WebhookServer.TLSConfig instead.
+	// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
 	TLSOpts []func(*tls.Config)
 
 	// WebhookServer is an externally configured webhook.Server. By default,