Add corresponding change in prs.md #110
Conversation
k8s-ci-robot
added
the
sig/contributor-experience
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guineveresaenger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
exercises/prs.md
Outdated
| @@ -10,7 +10,7 @@ See [issues.md](issues.md) for how to prepare for this exercise. If that prep h | |||
|
|
|||
| This exercise requires working knowledge of creating Github pull requests. If any students at the table have never done this before, their neighbors should help them. | |||
|
|
|||
| 1. Two students at the table (3 for 10-person tables) who have the status "reviewer" should each create a PR. Check the Owners file for status. | |||
| 1. Two students at the table (3 for 10-person tables) who are NOT in the OWNERS file as Reviewer or Approver should each create a PR. Check the Owners file for status. | |||
There was a problem hiding this comment.
We have OWNERS file in the root dir and separate OWNERS files for each KubeCon. It'd be good to make it clear which OWNERS file the students should check.
There was a problem hiding this comment.
"Check the Owners file ..." s/Owners/OWNERS
There was a problem hiding this comment.
That makes sense - added some clarity.
|
/assign @Smirl |
|
@markyjackson-taulia: GitHub didn't allow me to assign the following users: smirl. Note that only kubernetes-sigs members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@xiangpengzhao - PTAL ❤️ |
|
Sorry for late reply :) |
|
@xiangpengzhao: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @jberkus |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Fixes instructions to require non-OWNERS entries to open the initial PRs.
/assign @jberkus
/sig contributor-experience