feat: add support for additional CLI arg/env var extensions + add azure/kubelogin based example #27
Conversation
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @michaelawyu! |
k8s-ci-robot
added
the
size/L
michaelawyu
changed the title
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
| { | ||
| Name: "aks-workload-identity", | ||
| Cluster: clientcmdapiv1.Cluster{ | ||
| Server: "https://bravelion.hcp.eastus.azmk8s.io:443", |
There was a problem hiding this comment.
is this a real cluster?
| // here uses the environment variable form just to showcase the different ways of passing | ||
| // in additional information. | ||
| additionalEnvVars := map[string]string{ | ||
| "AZURE_CLIENT_ID": "CLIENT_ID", |
There was a problem hiding this comment.
"CLIENT_ID" is just a place holder here, right?
|
|
||
| // The additional arguments are cluster-specific information. | ||
| additionalArgs := []string{ | ||
| "--tenant-id", "TENANT_ID", |
There was a problem hiding this comment.
TENANT_ID is just a placeholder, right?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelawyu, ryanzhang-oss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| }, | ||
| }, | ||
| Status: v1alpha1.ClusterProfileStatus{ | ||
| CredentialProviders: []v1alpha1.CredentialProvider{ |
….20.4 🌱 Update to controller-runtime v0.20.4
3 participants
This PR adds support for the proposed additional CLI argument/environment variable extensions in the ClusterProfile API.
The PR is submitted right now to showcase how the system would function with the new extensions; it can be merged when PR #5559 (to the k8s/enhancements repo) is merged and all changes look good.