Skip to content

Conversation

killianmuldoon
Copy link
Contributor

Allow patch updates for the ignored dependencies in our dependabot config and group the k8s.io dependencies to reduce the number of individual PRs.

/area ci

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de9657b1ccaab09d8ef23493de1be866e0aea075

@killianmuldoon
Copy link
Contributor Author

/hold

For squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon
Copy link
Contributor Author

/tide merge-method-squash

To test for the release notes tool ref #9249

@killianmuldoon killianmuldoon added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 22, 2023
@killianmuldoon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this (or a link to PR where you already tested it maybe?) on the fork?

/lgtm

@sbueringer
Copy link
Member

We used everything apart from the groups in CAPV for a while and recently merged the groups there. Not sure if we explicitly tested the groups.

But as it's a just GitHub feature that we use, I'm fine with just trying it

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit cb36c47 into kubernetes-sigs:main Aug 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 23, 2023
@killianmuldoon
Copy link
Contributor Author

Not sure if we explicitly tested the groups.

I tested the groups on my own fork, but not on a schedule. I saw a couple of race conditions, but it's an improvement in any case IMO.

@sbueringer
Copy link
Member

Yup in the meantime we got a bunch of PRs opened and it looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants