-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 bump containerd to 1.6.18 in hack/tools #8523
🌱 bump containerd to 1.6.18 in hack/tools #8523
Conversation
Hi @tuminoid. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Should we bump to 1.6.20? Or 1.7.0 (not sure if there's breaking changes, but 1.6.18 is already out of date it looks like). |
Given it's a transitive dependency, maybe we should keep the delta to what the direct dependency is expecting as minimal as possible /lgtm Would be good to have an issue to explore if we can/should extend verify-container-images.sh to also scan the hack (and probably test) go modules. As of today they are just scanning our resulting images. |
LGTM label has been added. Git tree hash: 74747f39e76f46be0d2849f8c29e3457e4925cc1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/area devtools |
Bump containerd in hack/tools to 1.6.18 to close to two public vulnerabilities in containerd.
https://osv.dev/vulnerability/GHSA-259w-8hf6-59c2
https://osv.dev/vulnerability/GHSA-hmfx-3pcx-653p