🌱 Update golangci-lint and Go version for golangci-lint workflow

[oscr]

What this PR does / why we need it:

Updates the GitHub workflow to use Go 1.18 and bumps golangci-lint 1.44.0 -> 1.48.0. Also fixes findings by the upgraded linter.

Reference sources:
https://github.com/golangci/golangci-lint/releases
golangci/golangci-lint#2438

Part of #5968
Fixes #6350

[k8s-ci-robot]

Hi @oscr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

We need a version which includes #6350 (comment)

/hold

[sbueringer]

@oscr
Please add the following to the PR description

Part of #5968
Fixes #6350

(2nd one is true after the next golangci-lint release)

[oscr]

@oscr Please add the following to the PR description

Part of #5968 Fixes #6350

(2nd one is true after the next golangci-lint release)

Sure! I will bump the golangci-lint version as soon as it's available.

[sbueringer]

Perfect. Thank you!

lgtm so far

/ok-to-test

[sbueringer]

@oscr You can rebase once #6943 is merged

[killianmuldoon]

@oscr It would be good to dedupe this with #6943 - would you mind picking up tracking the linter update here as we move toward finally being able to update? 😆

[killianmuldoon]

Summary of learnings from #6943:

v1.47.1 does not work due to performance issues in the revive linter. v1.47.2 disables the problematic linters allowing that version of golangci-lint to be used on CAPI at the cost of some linter coverage.

At this point we could:

• Delay update for now and see if the bug can be fixed in the next couple of weeks
• Update but keep the exclusions in the config so we can roll them back once a fix is out
  @fabriziopandini WDYT?

[chrischdi]

Relevant for discussing if to delay or not: golangci/golangci-lint#2997 (comment)

List of disabled linters:

• var-declaration (default): https://revive.run/r#var-declaration
• errorf (default): https://revive.run/r#errorf
• unexported-return (default): https://revive.run/r#unexported-return
• time-naming (default): https://revive.run/r#time-naming
• context-keys-type (default): https://revive.run/r#context-keys-type
• modifies-value-receiver: https://revive.run/r#modifies-value-receiver
• range-val-address: https://revive.run/r#range-val-address
• string-of-int: https://revive.run/r#string-of-int
• time-equal: no documentation
• unhandled-error: https://revive.run/r#unhandled-error

[oscr]

I just want to highlight a change. When I cherry picked the changes from #6943 I got some nolintlint findings:

util/defaulting/defaulting.go:28:38: directive `//nolint:revive` is unused for linter "revive" (nolintlint)
type DefaultingValidator interface { //nolint:revive
                                     ^
cmd/clusterctl/client/alpha/rollout_pauser.go:39:92: directive `//nolint:revive // MachineDeployment is intentionally capitalized.` is unused for linter "revive" (nolintlint)
			return errors.Errorf("MachineDeploymet is already paused: %v/%v\n", ref.Kind, ref.Name) //nolint:revive // MachineDeployment is intentionally capitalized.
			                                                                                        ^
cmd/clusterctl/client/alpha/rollout_resumer.go:39:99: directive `//nolint:revive // MachineDeployment is intentionally capitalized.` is unused for linter "revive" (nolintlint)
			return errors.Errorf("MachineDeployment is not currently paused: %v/%v\n", ref.Kind, ref.Name) //nolint:revive // MachineDeployment is intentionally capitalized.
			                                                                                               ^
controlplane/kubeadm/internal/etcd/fake/client.go:26:30: directive `//nolint:revive` is unused for linter "revive" (nolintlint)
type FakeEtcdClient struct { //nolint:revive
                             ^
cmd/clusterctl/internal/test/fake_proxy.go:50:35: directive `//nolint:revive` is unused for linter "revive" (nolintlint)
	FakeScheme = runtime.NewScheme() //nolint:revive

So I temporary allowed unused in nolintlint until revive is fully enabled again.

nolintlint:
    allow-unused: true # TODO(oscr) Set to false when revive linter is fully enabled again.` 

I this ok?

[killianmuldoon]

So I temporary allowed unused in nolintlint until revive is fully enabled again.
I this ok?

Yeah - that's perfectly fine I think.

[oscr]

/test pull-cluster-api-e2e-informing-main

[killianmuldoon]

Part of #5968

[killianmuldoon]

Could you also bump the go versions in .golangci.yml? I think it's in there twice.

[killianmuldoon]

🤯

[killianmuldoon]

/lgtm

[oscr]

Sorry for the spam.

[sbueringer]

No worries :)

/lgtm

cc @killianmuldoon for a final look

[killianmuldoon]

/lgtm

Thanks again for following this one through @oscr!

[sbueringer]

Yup thank you very much!

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment