🐛 Report all KCP healthcheck errors #2451
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
| // It does some additional validation to make sure there is a 1;1 match between nodes and machines. | ||
| func (m *ManagementCluster) healthCheck(ctx context.Context, check healthCheck, clusterKey types.NamespacedName, controlPlaneName string) error { | ||
| nodeChecks, err := check(ctx) | ||
| errorList := []error{} |
There was a problem hiding this comment.
It can also be defined as var errorList []error since append will handle nil appropriately.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethp-nr, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sethp-nr can you squash down to 1 commit? |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Before: ``` E0225 23:47:06.883670 8 kubeadm_control_plane_controller.go:577] controllers/KubeadmControlPlane "msg"="waiting for control plane to pass etcd health check before adding an additional control plane machine" "error"="there are 3 control plane nodes, but 0 etcd members" "cluster"="test" "kubeadmControlPlane"="test" "namespace"="test" ``` After: ``` E0226 01:48:29.726200 166 kubeadm_control_plane_controller.go:577] controllers/KubeadmControlPlane "msg"="waiting for control plane to pass etcd health check before adding an additional control plane machine" "error"="[could not check etcd member health, node \"ip-10-0-0-3.ec2.internal\": failed to create etcd client: unable to create etcd client: context deadline exceeded, node \"ip-10-0-0-197.ec2.internal\": failed to create etcd client: unable to create etcd client: context deadline exceeded, node \"ip-10-0-0-59.ec2.internal\": failed to create etcd client: unable to create etcd client: context deadline exceeded]" "cluster"="test" "kubeadmControlPlane"="test" "namespace"="test" ```
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@sethp-nr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
What this PR does / why we need it:
Before:
After: