Skip to content

Comments

⚠️ Bump to controller-runtime main & controller-tools v0.20#13159

Merged
k8s-ci-robot merged 17 commits intokubernetes-sigs:mainfrom
sbueringer:pr-bump-cr-main-0.23
Dec 22, 2025
Merged

⚠️ Bump to controller-runtime main & controller-tools v0.20#13159
k8s-ci-robot merged 17 commits intokubernetes-sigs:mainfrom
sbueringer:pr-bump-cr-main-0.23

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 17, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12700

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2025
@sbueringer sbueringer changed the title [WIP] Bump to controller-runtime main [WIP] ⚠️ Bump to controller-runtime main Dec 17, 2025
@sbueringer sbueringer added the area/dependency Issues or PRs related to dependency changes label Dec 17, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Dec 17, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2025
@sbueringer sbueringer force-pushed the pr-bump-cr-main-0.23 branch 5 times, most recently from 8c75d48 to 7001337 Compare December 18, 2025 14:47
@sbueringer
Copy link
Member Author

sbueringer commented Dec 18, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer changed the title [WIP] ⚠️ Bump to controller-runtime main [WIP] ⚠️ Bump to controller-runtime main & controller-tools v0.20 Dec 18, 2025
@sbueringer sbueringer mentioned this pull request Dec 19, 2025
Open
4 tasks
@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/test pull-cluster-api-test-mink8s-main

@sbueringer sbueringer force-pushed the pr-bump-cr-main-0.23 branch 2 times, most recently from 27d7808 to cfe6c4e Compare December 19, 2025 08:41
@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/test ?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 19, 2025

@sbueringer: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-main-gke

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main

@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/assign @fabriziopandini

PR is ready for review
Merge is pending bump to a CR version that contains kubernetes-sigs/controller-runtime#3403

@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-test-mink8s-main

@sbueringer
Migrate Status().Patch() calls to Status().Apply()
97d3dce 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Adjust to changes in the prometheus library
6b318f3 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Fix gci finding
ecbf101
@sbueringer
Add exclude for mgr.GetEventRecorderFor deprecation
380b2e3 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Make MachineSet syncMachines test more robust
bfeed06
@sbueringer
Copy link
Member Author

sbueringer commented Dec 19, 2025

/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-test-mink8s-main

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Dec 19, 2025
@sbueringer sbueringer mentioned this pull request Dec 19, 2025
Merged
fabriziopandini
fabriziopandini reviewed Dec 22, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@fabriziopandini
Copy link
Member

fabriziopandini commented Dec 22, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 22, 2025

LGTM label has been added.

DetailsGit tree hash: 3ba38a354d2b8e7fbace012a1a25690f45eb0542

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit bae4252 into kubernetes-sigs:main Dec 22, 2025
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Dec 22, 2025
@sbueringer sbueringer deleted the pr-bump-cr-main-0.23 branch December 22, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @fabriziopandini