🌱 Add test/framework/* tests in CI

[arshadd-b]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##12364

[k8s-ci-robot]

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/ok-to-test

[sbueringer]

Change looks good. Can you please just make a quick test here on the PR that it actually works end to end and leads to a failed test job.

I would suggest to simply change this text:

cluster-api/test/framework/deployment_helpers_test.go

Line 71 in 64864e4

wantErr: "1 panics occurred in \"cluster\" controller (check logs for more details)",

[arshadd-b]

Change looks good. Can you please just make a quick test here on the PR that it actually works end to end and leads to a failed test job.

I would suggest to simply change this text:

cluster-api/test/framework/deployment_helpers_test.go

Line 71 in 64864e4

wantErr: "1 panics occurred in \"cluster\" controller (check logs for more details)",

sure, will make the change

[sbueringer]

Perfect thx, can be reverted

[sbueringer]

/lgtm
/approve

Thank you!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 046d9fa4e2176c766f3bca9159d7a80186521865

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment