📖 Refactor InfraCluster contract #11213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/documentation
k8s-ci-robot
added
size/XL
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 4c817617634460cde9c580801062c9816128aafb
|
chrischdi
reviewed
Sep 23, 2024
k8s-ci-robot
removed
the
lgtm
sbueringer
reviewed
Sep 23, 2024
sbueringer
reviewed
Sep 23, 2024
fabriziopandini
force-pushed
the
refactor-infracluster-contract
branch
from
e2fc595 to
76c99ab
Compare
Member
|
Thx, really nice improvement! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: e6feac736d4a74b44fc9c4d3605eff13075b7805
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
59 tasks
pierrecregut
added a commit
to pierrecregut/metal3-docs
that referenced
this pull request
Sep 30, 2025
The contract has been diluted and removed from the cluster-api book (kubernetes-sigs/cluster-api#11213) makding it hard to reference it. Signed-off-by: Pierre Crégut <pierre.cregut@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactor the InfraCluster contract. Most notably
/area documentation