Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update CAPI support and guarantees for v1.9 #11163

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

chandankumar4
Copy link
Contributor

What this PR does / why we need it:

  • This PR updates the supported versions for the release cycle (1.9).

@kubernetes-sigs/cluster-api-release-team

/area documentation

Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chandankumar4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
only note from my side:

There are two half on this PR

  • Drop 1.5 column, mark 1.6 version as EOL
  • Add 1.9 column

The first half has to be back ported to the release-1.8 branch, the second no.
I'm not sure how this has been done in the past, but please keep it in mind for the backport

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5e91cb4c63e42e95580b7f86fa1d9dc3d0af228

@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
@fabriziopandini
Copy link
Member

/hold

This seems a duplicate of #11151
cc @Sunnatillo

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024
@fabriziopandini
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@fabriziopandini
Copy link
Member

@chandankumar4 could you kindly open the manual cherry pick as per #11163 (review)?

@k8s-ci-robot k8s-ci-robot merged commit f9738ac into kubernetes-sigs:main Sep 11, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 11, 2024
@sbueringer
Copy link
Member

Usually we don't add information about v1.9 to the v1.8 book. Or do you mean only cherry-pick a subset of this PR?

@fabriziopandini
Copy link
Member

I have raised the same question in #11163 (review), proposing a manual cherry pick that we need as soon as possible (1.6 is EOS from ~1m now, and the book still reports it as supported).
cc @Sunnatillo

@sbueringer
Copy link
Member

Ah my bad, missed that comment. Makes sense!

@chandankumar4 chandankumar4 deleted the update-version-1.9 branch September 12, 2024 10:25
@chandankumar4
Copy link
Contributor Author

Have raised the manual cherry-pick PR #11177
@fabriziopandini

@Sunnatillo
Copy link
Contributor

Part of #11092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants