Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubelet and kubeproxy configuration in KubeadmConfigSpec #1744

Closed
accepting opened this issue Nov 9, 2019 · 3 comments
Closed

Add kubelet and kubeproxy configuration in KubeadmConfigSpec #1744

accepting opened this issue Nov 9, 2019 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@accepting
Copy link
Contributor

User Story

KubeadmConfigSpec should have the ability to config kubelet and kubeproxy parameters that kubeadm supports.

Detailed Description

When using kubeadm to setup a cluster, we need to config kubelet and kubeproxy parameters. But with the current version of KubeadmConfigSpec we cannot do that. We hope KubeadmConfigSpec can be added another two fields:

type KubeadmConfigSpec struct {
        ...
	KubeProxyConfiguration *kubeadmv1beta1.KubeProxyConfiguration `json:"kubeProxyConfiguration,omitempty"`
        KubeProxyConfiguration *kubeadmv1beta1.KubeProxyConfiguration `json:"kubeProxyConfiguration,omitempty"`

With this feature, we can config bootstrap as follows

spec:
  template:
    apiVersion: xxxx
    kind: Bootstrap
    spec:
      clusterConfiguration:
        apiVersion: kubeadm.k8s.io/v1beta1
        kind: ClusterConfiguration
        ...
      joinConfiguration:
        apiVersion: kubeadm.k8s.io/v1beta1
        kind: JoinConfiguration
        ...
      initConfiguration:
        apiVersion: kubeadm.k8s.io/v1beta1
        kind: InitConfiguration
        ...
      kubeletConfiguration:
        apiVersion: kubelet.config.k8s.io/v1beta1
        kind: KubeletConfiguration
        systemReserved:
          cpu: 500m
          memory: 500M
        systemReservedCgroup: "cgroupfs"
          cgroupDriver: "cgroupfs"
          configMapAndSecretChangeDetectionStrategy: "Cache"
          readOnlyPort: 10255
      kubeProxyConfiguration:
         apiVersion: kubeproxy.config.k8s.io/v1alpha1
         kind: KubeProxyConfiguration
         metricsBindAddress: "0.0.0.0:10249"

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2019
@accepting
Copy link
Contributor Author

@chuckha

@ncdc
Copy link
Contributor

ncdc commented Nov 13, 2019

This was requested in #1584 - closing as a duplicate.
/close

@k8s-ci-robot
Copy link
Contributor

@ncdc: Closing this issue.

In response to this:

This was requested in #1584 - closing as a duplicate.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants