Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Waiting for Node volumes to be detached" log message #11108

Open
sbueringer opened this issue Aug 28, 2024 · 6 comments
Open

Improve "Waiting for Node volumes to be detached" log message #11108

sbueringer opened this issue Aug 28, 2024 · 6 comments
Assignees
Labels
area/logging Issues or PRs related to logging help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Aug 28, 2024

Follow-up to: #11074 (comment)

This issue is about improving the "Waiting for Node volumes to be detached" log message added in #11074.

Open questions:
a) should we add details about the volumes that we are still waiting for?
b) which information about the volumes should be added to the logs (e.g. are the AttachedVolume.name fields useful to users?)
c) Should we add something to the condition?

Context:

// AttachedVolume describes a volume attached to a node
type AttachedVolume struct {
	// Name of the attached volume
	Name UniqueVolumeName `json:"name" protobuf:"bytes,1,rep,name=name"`

	// DevicePath represents the device path where the volume should be available
	DevicePath string `json:"devicePath" protobuf:"bytes,2,rep,name=devicePath"`
}
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 28, 2024
@sbueringer
Copy link
Member Author

sbueringer commented Aug 28, 2024

/cc @enxebre @fabriziopandini

@sbueringer
Copy link
Member Author

/triage accepted
/area logging
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/logging Issues or PRs related to logging priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Aug 28, 2024
@sbueringer sbueringer added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Aug 28, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Aug 28, 2024
@sbueringer sbueringer changed the title Improve waiting for Node volumes to be detached log message Improve "Waiting for Node volumes to be detached" log message Aug 28, 2024
@sbueringer
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 28, 2024
@sivchari
Copy link
Member

I'd take this task.
/assign

@sbueringer
Copy link
Member Author

Thx. I think we need some real life data to figure out what we can put in the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to logging help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants