🌱 lint: remove skip-files for api/v1alpha3 #2378

adityabhatia · 2023-09-21T18:56:20Z

What this PR does / why we need it:
This PR removes api/v1alpha3 files from golangci-lint skip-files config and fixes underlying lint issues.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #2058

k8s-ci-robot · 2023-09-21T18:56:30Z

Hi @adityabhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2023-09-22T07:50:55Z

/ok-to-test

codecov · 2023-09-22T07:55:01Z

Codecov Report

Patch coverage: 44.00% and project coverage change: +0.57% 🎉

Comparison is base (c2dd905) 60.54% compared to head (47785f1) 61.11%.
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   60.54%   61.11%   +0.57%     
==========================================
  Files         164      164              
  Lines        9392     9469      +77     
==========================================
+ Hits         5686     5787     +101     
+ Misses       3292     3275      -17     
+ Partials      414      407       -7

Files Changed	Coverage Δ
apis/v1alpha3/types.go	`0.00% <ø> (ø)`
apis/v1alpha3/vspherecluster_types.go	`33.33% <0.00%> (ø)`
apis/v1alpha3/vsphereclusteridentity_conversion.go	`0.00% <0.00%> (ø)`
apis/v1alpha3/vsphereclusteridentity_types.go	`33.33% <0.00%> (ø)`
apis/v1alpha3/vspheredeploymentzone_conversion.go	`0.00% <0.00%> (ø)`
apis/v1alpha3/vspheredeploymentzone_types.go	`100.00% <ø> (ø)`
apis/v1alpha3/vspherefailuredomain_conversion.go	`0.00% <0.00%> (ø)`
apis/v1alpha3/vspheremachine_types.go	`33.33% <0.00%> (ø)`
apis/v1alpha3/vspherevm_types.go	`33.33% <0.00%> (ø)`
apis/v1alpha3/conversion.go	`100.00% <100.00%> (ø)`
... and 2 more

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrischdi · 2023-09-22T07:53:42Z

apis/v1alpha3/vspherecluster_types.go

 	// vSphere server's certificate.
-	// DEPRECATED: will be removed in v1alpha4
+	// Depracated: will be removed in v1alpha4


Suggested change

// Depracated: will be removed in v1alpha4

// Deprecated: will be removed in v1alpha4.

Also for the other occurencies :-)

chrischdi · 2023-09-22T07:54:07Z

apis/v1alpha3/vspherecluster_types.go

-	// ClusterFinalizer allows ReconcileVSphereCluster to clean up vSphere
-	// resources associated with VSphereCluster before removing it from the
-	// API server.
-	ClusterFinalizer = "vspherecluster.infrastructure.cluster.x-k8s.io"


We should not remove this.

killianmuldoon · 2023-09-22T09:17:57Z

apis/v1alpha3/cloudprovider_types.go

@@ -27,7 +27,7 @@ limitations under the License.
 package v1alpha3

 // CPIConfig is the vSphere cloud provider's configuration.
-// DEPRECATED: will be removed in v1alpha4
+// Depracated: will be removed in v1alpha4.


Suggested change

// Depracated: will be removed in v1alpha4.

//

// Deprecated: will be removed in v1alpha4.

Go needs Deprecated to be ona new line for it to be picked up by tooling.

killianmuldoon

Looks good - only fixups are to spelling and spacing for deprecated markers.

Thanks!

killianmuldoon

/lgtm

Thanks!

k8s-ci-robot · 2023-09-22T15:17:25Z

LGTM label has been added.

Git tree hash: 1f75a7b7f7a7679da919a91db26747cff174121f

killianmuldoon · 2023-09-22T15:18:43Z

/hold

@adityabhatia do you mind squashing the commits?

chrischdi

/approve

k8s-ci-robot · 2023-09-25T06:14:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

killianmuldoon · 2023-09-25T07:28:10Z

/lgtm
/hold cancel

k8s-ci-robot · 2023-09-25T07:28:15Z

LGTM label has been added.

Git tree hash: 1f75a7b7f7a7679da919a91db26747cff174121f

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2023

k8s-ci-robot requested review from MaxRink and zhanggbj September 21, 2023 18:56

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2023

adityabhatia changed the title ~~remove skip-files for api/v1alpha3~~ 🌱 remove skip-files for api/v1alpha3 Sep 21, 2023

adityabhatia changed the title ~~🌱 remove skip-files for api/v1alpha3~~ 🌱 lint: remove skip-files for api/v1alpha3 Sep 21, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2023

chrischdi mentioned this pull request Sep 22, 2023

Audit golangci-lint config #2058

Closed

chrischdi reviewed Sep 22, 2023

View reviewed changes

killianmuldoon reviewed Sep 22, 2023

View reviewed changes

adityabhatia force-pushed the v1alpha3-remove-skip-files branch from accd24a to a794d36 Compare September 22, 2023 14:35

killianmuldoon reviewed Sep 22, 2023

View reviewed changes

k8s-ci-robot assigned killianmuldoon Sep 22, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2023

adityabhatia force-pushed the v1alpha3-remove-skip-files branch from a794d36 to 08de607 Compare September 22, 2023 15:23

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2023

k8s-ci-robot requested a review from killianmuldoon September 22, 2023 15:23

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2023

remove skip-files for api/v1alpha3

47785f1

adityabhatia force-pushed the v1alpha3-remove-skip-files branch from 08de607 to 47785f1 Compare September 22, 2023 15:26

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2023

chrischdi reviewed Sep 25, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 25, 2023

k8s-ci-robot merged commit 29f9ef7 into kubernetes-sigs:main Sep 25, 2023
18 checks passed

k8s-ci-robot added this to the v1.9 milestone Sep 25, 2023

adityabhatia mentioned this pull request Jan 26, 2024

REQUEST: New membership for adityabhatia kubernetes/org#4724

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 lint: remove skip-files for api/v1alpha3 #2378

🌱 lint: remove skip-files for api/v1alpha3 #2378

adityabhatia commented Sep 21, 2023

k8s-ci-robot commented Sep 21, 2023

chrischdi commented Sep 22, 2023

codecov bot commented Sep 22, 2023 •

edited

Loading

chrischdi Sep 22, 2023

chrischdi Sep 22, 2023

killianmuldoon Sep 22, 2023

killianmuldoon left a comment

killianmuldoon left a comment

k8s-ci-robot commented Sep 22, 2023

killianmuldoon commented Sep 22, 2023

chrischdi left a comment

k8s-ci-robot commented Sep 25, 2023

killianmuldoon commented Sep 25, 2023

k8s-ci-robot commented Sep 25, 2023

	// Depracated: will be removed in v1alpha4
	// Deprecated: will be removed in v1alpha4.

🌱 lint: remove skip-files for api/v1alpha3 #2378

🌱 lint: remove skip-files for api/v1alpha3 #2378

Conversation

adityabhatia commented Sep 21, 2023

k8s-ci-robot commented Sep 21, 2023

chrischdi commented Sep 22, 2023

codecov bot commented Sep 22, 2023 • edited Loading

Codecov Report

chrischdi Sep 22, 2023

Choose a reason for hiding this comment

chrischdi Sep 22, 2023

Choose a reason for hiding this comment

killianmuldoon Sep 22, 2023

Choose a reason for hiding this comment

killianmuldoon left a comment

Choose a reason for hiding this comment

killianmuldoon left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 22, 2023

killianmuldoon commented Sep 22, 2023

chrischdi left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 25, 2023

killianmuldoon commented Sep 25, 2023

k8s-ci-robot commented Sep 25, 2023

codecov bot commented Sep 22, 2023 •

edited

Loading