🏃 Improve ci script patching #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-provider-openstack-e2e-test |
k8s-ci-robot
added
the
size/XXL
sbueringer
changed the title
sbueringer
force-pushed
the
pr-improve-ci-script-patching
branch
from
b9109b4 to
3fced5b
Compare
k8s-ci-robot
added
size/XL
|
/test pull-cluster-api-provider-openstack-e2e-test @jichenjc @hidekazuna please take a look, if you have some time :) PR is now ready for review/merge after I merged the other PR and dropped the commit. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #804
Special notes for your reviewer:
I will try to upstream this code to the cluster-api repo, but in the meantime we can use the cleanup already in our repo.
This includes PR #798. After #798 the redundant commit will be dropped.#798 has been merged, so now this PR does not contain commits of any other PRs anymore.TODOs:
/hold