🌱Fix various issues with CRD generation #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
The change to generated go build metadata requires a small change in boilerplate verification.
k8s-ci-robot
added
size/XL
lentzi90
reviewed
Sep 14, 2023
Comment on lines
+23
to
+34
| - target: | ||
| group: admissionregistration.k8s.io | ||
| version: v1 | ||
| kind: MutatingWebhookConfiguration | ||
| name: mutating-webhook-configuration | ||
| path: cainjection_patch.yaml | ||
| - target: | ||
| group: admissionregistration.k8s.io | ||
| version: v1 | ||
| kind: ValidatingWebhookConfiguration | ||
| name: validating-webhook-configuration | ||
| path: cainjection_patch.yaml |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/cherry-pick release-0.8 |
|
@mdbooth: new pull request created: #1671 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kustomize was emitting warnings due to use of deprecated methods. The first commit addresses all of these except use of
vars.We were also hitting kubernetes-sigs/kustomize#5031. Although this is still broken in kustomize, there is a workaround in kubernetes-sigs/controller-tools#800, so we bump controller-tools to get the fix.
/hold