Skip to content

Fixed bootVolume name bug #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Fixed bootVolume name bug #2297

merged 1 commit into from
Apr 7, 2025

Conversation

anshuman-agarwala
Copy link
Member

@anshuman-agarwala anshuman-agarwala commented Apr 6, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2260

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Fixed bug where adding volume name with multiple worker nodes would cause errors due to unique volume name constraint.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/ibmcloud Issues or PRs related to ibmcloud provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @anshuman-agarwala. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 6, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 022ea96
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67f369a82c9c1f0008a6d4ef
😎 Deploy Preview https://deploy-preview-2297.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Karthik-K-N
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2025
Prajyot-Parab
Prajyot-Parab reviewed Apr 7, 2025
View reviewed changes
cloud/scope/machine.go
}

if volume.Name != "" {
bootVolume.Volume.Name = core.StringPtr(volume.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volume.Name spec is intended to be assigned to bootVolume.Volume.Name or bootVolume.Name ?
what would be the value of bootVolume.Volume.Name post this change?

If unspecified, the name will
	// be a hyphenated list of randomly-selected words.

is this the flow expectation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the boot volume name is expected to be random. This is required because when we add a volume name to the bootvolume the machine creation fails as each machine tries to create and mount a volume with the same name in their shared workspace which is not supported by IBMCloud.

@Prajyot-Parab
Copy link
Contributor

/cc @Karthik-K-N

@k8s-ci-robot k8s-ci-robot requested a review from Karthik-K-N April 7, 2025 06:56
@Prajyot-Parab
Copy link
Contributor

@anshuman-agarwala Please update the release note in description.

Prajyot-Parab
Prajyot-Parab reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2025
Karthik-K-N
Karthik-K-N reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anshuman-agarwala, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7df8c1b into kubernetes-sigs:main Apr 7, 2025
14 checks passed
@anshuman-agarwala anshuman-agarwala mentioned this pull request Sep 10, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab left review comments

@mkumatag mkumatag mkumatag approved these changes

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

+1 more reviewer

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Karthik-K-N Karthik-K-N

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster provisioning fails when BootVolume Name is specified
5 participants
@anshuman-agarwala @k8s-ci-robot @Karthik-K-N @Prajyot-Parab @mkumatag