Enhanced updateCondition function

[pjsharath28]

What this PR does / why we need it:
The existing implementation of updateCondition in IBM PowerVS Cluster Controller was a bit problematic as it expected interface type, Without the length and type check we could run into null pointer dereferencing and index out of bound conditions. This PR helps resolve the same.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2115

Special notes for your reviewer:
For testing my changes, I made a local setup using tilt and created the cluster using following command:

IBMCLOUD_API_KEY=<api-key-here> \
  IBMPOWERVS_SSHKEY_NAME="sharath-sshkey" \
  COS_BUCKET_REGION="us-south" \
  COS_BUCKET_NAME="power-oss-bucket" \
  COS_OBJECT_NAME=capibm-powervs-centos-streams8-1-28-4-1707287079.ova.gz \
  IBMACCOUNT_ID="c265c8cefda241ca9c107adcbbacaa84" \
  IBMPOWERVS_REGION="wdc" \
  IBMPOWERVS_ZONE="wdc06" \
  IBMVPC_REGION="us-east" \
  IBM_RESOURCE_GROUP="ibm-hypershift-dev" \
  BASE64_API_KEY=$(echo -n $IBMCLOUD_API_KEY | base64) \
  clusterctl generate cluster capi-powervs --kubernetes-version v1.28.4 \
  --target-namespace default \
  --control-plane-machine-count=3 \
  --worker-machine-count=1 \
  --from=./templates/cluster-template-powervs-create-infra.yaml | kubectl apply -f -

I observed that the conditions were true for all resources as shown below:

Status:
  Conditions:
    Last Transition Time:  2025-01-15T10:51:24Z
    Status:                True
    Type:                  LoadBalancerReady
    Last Transition Time:  2025-01-15T10:53:54Z
    Status:                True
    Type:                  NetworkReady
    Last Transition Time:  2025-01-15T10:44:20Z
    Status:                True
    Type:                  ServiceInstanceReady
    Last Transition Time:  2025-01-15T10:48:26Z
    Status:                True
    Type:                  TransitGatewayReady
    Last Transition Time:  2025-01-15T10:43:58Z
    Status:                True
    Type:                  VPCReady
    Last Transition Time:  2025-01-15T10:44:03Z
    Status:                True
    Type:                  VPCSecurityGroupReady
    Last Transition Time:  2025-01-15T10:44:03Z
    Status:                True
    Type:                  VPCSubnetReady

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Enhanced updateCondition function

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pjsharath28 / name: Sharath P J (327d4bc)

[k8s-ci-robot]

Welcome @pjsharath28!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pjsharath28. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	327d4bc
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67889a15ac57d700085a7849
😎 Deploy Preview	https://deploy-preview-2135--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Amulyam24]

/ok-to-test

[Prajyot-Parab]

@pjsharath28 update release note to -> Enhanced updateCondition function

[Prajyot-Parab]

/lgtm

[Karthik-K-N]

@dharaneeshvrd Please take a look when you get some time.

/hold till then
feel free to unhold if all good. Thanks.

[dharaneeshvrd]

/unhold
LGTM!

[Prajyot-Parab]

/approve
Thank You @pjsharath28

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjsharath28, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Prajyot-Parab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment