Skip to content

Conversation

Amulyam24
Copy link
Contributor

@Amulyam24 Amulyam24 commented Nov 25, 2024

What this PR does / why we need it:
Update cluster-api to v1.9.x, the following changes are made

  1. Update k8s to 1.31
  2. sigs.k8s.io/cluster-api/errors is deprecated, move away from it
  3. While setting up the controllers, functions returning predicates accept an additional argument
  4. Replaced the deprecated ClusterUnpausedAndInfrastructureReady with ClusterPausedTransitionsOrInfrastructureReady, ref - 🌱 Deprecate old pausing predicates cluster-api#11300

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2056

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update cluster-api to v1.9.x

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 25, 2024
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 0d9c8f1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67517b9ba3070100087e58d9
😎 Deploy Preview https://deploy-preview-2069--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2024
@Amulyam24
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2024
@Amulyam24 Amulyam24 changed the title Update cluster-api to v1.9.0-beta.1 update cluster-api to v1.9.x Dec 3, 2024
@Amulyam24 Amulyam24 changed the title update cluster-api to v1.9.x Update cluster-api to v1.9.x Dec 3, 2024
@Amulyam24
Copy link
Contributor Author

/retest

@Amulyam24 Amulyam24 force-pushed the capi-update branch 2 times, most recently from e2d3592 to ec4406a Compare December 3, 2024 10:37
@mkumatag
Copy link
Member

mkumatag commented Dec 3, 2024

@Amulyam24 can you mention all the changes made with more information

@Amulyam24
Copy link
Contributor Author

/unhold

PR is ready for review @Prajyot-Parab @mkumatag

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6c8d211 into kubernetes-sigs:main Dec 5, 2024
12 of 13 checks passed
@Amulyam24 Amulyam24 mentioned this pull request Apr 1, 2025
19 tasks
@Karthik-K-N Karthik-K-N mentioned this pull request Jun 12, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI v1.9.0-beta.0 has been released and is ready for testing
3 participants