Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
code review suggestions

Co-authored-by: Amulya Meka <amulyameka38@gmail.com>
  • Loading branch information
carmal891 and Amulyam24 authored Oct 7, 2024
1 parent 9c6bdf5 commit 7a6cc35
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cloud/scope/powervs_cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,7 @@ func TestReconcileLoadBalancers(t *testing.T) {

mockVpc.EXPECT().GetLoadBalancer(gomock.Any()).Return(&vpcv1.LoadBalancer{
ID: core.StringPtr("test-lb-instanceid"),
ProvisioningStatus: core.StringPtr("pending"),
ProvisioningStatus: core.StringPtr("update_pending"),
Name: core.StringPtr("test-lb"),
}, nil, nil)

Expand Down Expand Up @@ -1216,7 +1216,7 @@ func TestReconcileLoadBalancers(t *testing.T) {
},
}

mockVpc.EXPECT().GetLoadBalancerByName(gomock.Any()).Return(nil, errors.New("loadBalancer list returned is nil"))
mockVpc.EXPECT().GetLoadBalancerByName(gomock.Any()).Return(nil, errors.New("failed to get load balancer by name"))

requeue, err := clusterScope.ReconcileLoadBalancers()
g.Expect(requeue).To(BeFalse())
Expand Down

0 comments on commit 7a6cc35

Please sign in to comment.