Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ginko to v2, CAPI to 1.3.x, go to 1.19 and certmanager to v1.10.0 #766

Merged
merged 1 commit into from
Dec 1, 2022
Merged

update ginko to v2, CAPI to 1.3.x, go to 1.19 and certmanager to v1.10.0 #766

merged 1 commit into from
Dec 1, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 25, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

  • update ginko to v2, CAPI to 1.3.x, go to 1.19 and certmanager to v1.10.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

update ginko to v2, CAPI to 1.3.x, go to 1.19 and certmanager to v1.10.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

This will require update the prow jobs

@cpanato cpanato mentioned this pull request Nov 25, 2022
Merged
@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

prow job update: kubernetes/test-infra#28115

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/retest all

@k8s-ci-robot
Copy link
Contributor

@cpanato: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-gcp-apidiff
  • /test pull-cluster-api-provider-gcp-capi-e2e
  • /test pull-cluster-api-provider-gcp-conformance
  • /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
  • /test pull-cluster-api-provider-gcp-coverage
  • /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-gcp-apidiff
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-e2e-test
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-verify

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/test all

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/test pull-cluster-api-provider-gcp-conformance

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/test pull-cluster-api-provider-gcp-conformance

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/test pull-cluster-api-provider-gcp-capi-e2e

@cpanato
Copy link
Member Author

cpanato commented Nov 25, 2022

/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance

@cpanato
Copy link
Member Author

cpanato commented Nov 28, 2022

/test pull-cluster-api-provider-gcp-conformance

@cpanato
Copy link
Member Author

cpanato commented Nov 28, 2022

/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato cpanato changed the title [WIP] update GINKGO update ginko to v2, CAPI to 1.3.x, go to 1.19 and certmanager to v1.10.0 Nov 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2022
@cpanato
Copy link
Member Author

cpanato commented Nov 28, 2022

/assign @dims @richardcase @sbueringer @fabriziopandini

this is the one :)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@cpanato
Copy link
Member Author

cpanato commented Nov 28, 2022

/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

sbueringer
sbueringer reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me just some optional nits

/lgtm

Tiltfile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
scripts/ci-conformance.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2022
@cpanato
Copy link
Member Author

cpanato commented Nov 29, 2022

/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance-ci-artifacts
/test pull-cluster-api-provider-gcp-e2e-workload-upgrade
/test pull-cluster-api-provider-gcp-conformance

@sbueringer
Copy link
Member

sbueringer commented Nov 29, 2022 •
edited
Loading

Thx!

/lgtm
(assuming green CI of course :))

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2022
@k8s-ci-robot
Copy link
Contributor

@cpanato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-apidiff 13cf1fe link false /test pull-cluster-api-provider-gcp-apidiff
pull-cluster-api-provider-gcp-e2e-workload-upgrade 13cf1fe link false /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cpanato
Copy link
Member Author

cpanato commented Dec 1, 2022

i will fix the pull-cluster-api-provider-gcp-e2e-workload-upgrade in a follow up, this is not required for now

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7ef8c28 into kubernetes-sigs:main Dec 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Dec 1, 2022
@cpanato cpanato deleted the upgrade-ginko-gomega branch December 1, 2022 15:08
@damdo damdo mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@dims dims Awaiting requested review from dims

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@dims dims

@richardcase richardcase

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @k8s-ci-robot @sbueringer @dims @richardcase @fabriziopandini