Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-gen patch version #1085

Merged

Conversation

damdo
Copy link
Member

@damdo damdo commented Nov 30, 2023

/kind bug

Certain versions of specific k8s packages and tools (e.g. clusterctl, kustomize) do not like the creationTimestamp: null field on k8s manifests, throwing errors like
Kind=CustomResourceDefinition: parsing time "null" as "2006-01-02T15:04:05Z07:00": cannot parse "null" as "2006"

Although this is, for example, still broken for kustomize (see: kubernetes-sigs/kustomize#5031) there is a workaround in kubernetes-sigs/controller-tools#800, so we can bump controller-tools' controller-gen to get the fix.

bump controller-gen patch version + manifests regeneration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2023
@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims November 30, 2023 10:24
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2023
@damdo
Copy link
Member Author

damdo commented Dec 1, 2023

/assign @richardcase

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@cpanato
Copy link
Member

cpanato commented Dec 2, 2023

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@cpanato: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 393a7e4 into kubernetes-sigs:main Dec 2, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Dec 2, 2023
@k8s-infra-cherrypick-robot

@cpanato: new pull request created: #1090

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Dec 2, 2023

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@cpanato: new pull request created: #1092

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants