Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Kubernetes Community-Owned Package Repositories and update go 1.20.11 #1064

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Switch to Kubernetes Community-Owned Package Repositories and update go 1.20.11 #1064

merged 4 commits into from
Nov 21, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 5, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Switch to Kubernetes Community-Owned Package Repositories
  • Removed kubectl --short flag (deprecated)
  • bump go to 1.20.11

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

- Switch to Kubernetes Community-Owned Package Repositories
- Removed kubectl --short flag (deprecated)
- bump go to 1.20.11

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2023
@cpanato
Copy link
Member Author

cpanato commented Nov 5, 2023

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-gcp-apidiff
  • /test pull-cluster-api-provider-gcp-capi-e2e
  • /test pull-cluster-api-provider-gcp-conformance
  • /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
  • /test pull-cluster-api-provider-gcp-coverage
  • /test pull-cluster-api-provider-gcp-coverage-release-1-4
  • /test pull-cluster-api-provider-gcp-coverage-release-1-5
  • /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-gcp-apidiff
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-e2e-test
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2023
@cpanato cpanato marked this pull request as draft November 5, 2023 11:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2023
@cpanato
Copy link
Member Author

cpanato commented Nov 6, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

2 similar comments
@cpanato
Copy link
Member Author

cpanato commented Nov 8, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Nov 8, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
@cpanato cpanato changed the title WIP testing ci-artifcats job Switch to Kubernetes Community-Owned Package Repositories and update go 1.20.11 Nov 8, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 8, 2023
@cpanato cpanato marked this pull request as ready for review November 8, 2023 22:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
@cpanato
Copy link
Member Author

cpanato commented Nov 8, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

1 similar comment
@cpanato
Copy link
Member Author

cpanato commented Nov 9, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Nov 9, 2023

/assign @richardcase

@cpanato
Switch to Kubernetes Community-Owned Package Repositories
d29315a 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Removed kubectl --short flag (deprecated)
c274f85 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
bump go to 1.20.11
99ab649 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Nov 16, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
fix ci build because it is running on a eks cluster
d55c2d6 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Nov 16, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

1 similar comment
@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Nov 21, 2023

/assign @richardcase @dims

@dims
Copy link
Member

dims commented Nov 21, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0922d18 into kubernetes-sigs:main Nov 21, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Nov 21, 2023
@cpanato cpanato deleted the debug-ci-artifacts branch November 21, 2023 12:20
@cpanato
Copy link
Member Author

cpanato commented Dec 2, 2023

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 2, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@cpanato: new pull request created: #1091

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@dims dims

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @dims @k8s-infra-cherrypick-robot @richardcase