✨ Add aggregated role support #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
cncf-cla: yes
Danil-Grigorev
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4933 +/- ##
=======================================
Coverage 62.19% 62.19%
=======================================
Files 201 201
Lines 16878 16878
=======================================
Hits 10497 10497
Misses 5591 5591
Partials 790 790 ☔ View full report in Codecov by Sentry. |
|
Both failures look like flakes: |
5 tasks
k8s-ci-robot
added
release-note
Danil-Grigorev
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 40a2e7af67358900925e3df4e794f861fa7480f0
|
mboersma
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
/lgtm
/approve
Cool, thanks! I had to read up on Cluster Role aggregationRule to understand. 👍🏻
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
CAPZ provider might need to have an ability to extend default set of RBAC, depending on deployment model or use cases, like with changes proposed in #4931. Splitting this out to test and improve on the changes separately.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: