-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.9] fix AuthorizedIPRanges disable -> enable bug #3807
[release-1.9] fix AuthorizedIPRanges disable -> enable bug #3807
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #3807 +/- ##
===============================================
+ Coverage 52.90% 52.95% +0.05%
===============================================
Files 182 182
Lines 18250 18264 +14
===============================================
+ Hits 9655 9672 +17
+ Misses 8055 8053 -2
+ Partials 540 539 -1
☔ View full report in Codecov by Sentry. |
I will squash the commits once lgtm-ed. |
/lgtm /hold for squash |
LGTM label has been added. Git tree hash: fae36b8419d0df55534549aeace89bfddff9fc27
|
/lgtm |
- update AzureSDK once with empty slice and then ignore changes
3aa1bb3
to
43ae4cb
Compare
Squashed :) /unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
//nolint:gocyclo
to theParameters()
function from main since [release-1.10] fix AuthorizedIPRanges disable -> enable bug #3800 was erroring out on go-cyclomexic complexity (A lot of nil checks).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
TODOs:
Release note: