Fix retrying in Helm e2e helper func #3789
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
|
/cc @Jont828 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4ba49f49587de8d3948ab4807c0bd18c35eccbcf
|
| cmd := exec.Command(helm, args...) | ||
| Logf("Helm command: %s", cmd.String()) | ||
| output, err := cmd.CombinedOutput() | ||
| Logf("Helm install output: %s", string(output)) | ||
| Expect(err).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
FWIW, I think g.Expect(...) would have also fixed this issue.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3789 +/- ##
=======================================
Coverage 54.38% 54.38%
=======================================
Files 187 187
Lines 19015 19015
=======================================
Hits 10342 10342
Misses 8115 8115
Partials 558 558 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-1.10 |
|
@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mboersma: new pull request created: #3790 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mboersma: new pull request created: #3791 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Fixes a logic error in the refactoring of the
InstallHelmCharthelper function so it retries as intended if the command returns an error.Which issue(s) this PR fixes:
Fixes #3787
Special notes for your reviewer:
I created a demo Ginkgo test suite to reproduce this and isolate the problem, then ported the now-obvious fix back to CAPZ. I did a before-and-after test locally with
./scripts/ci-e2e.shand verified that we aren't currently retrying but that this change fixes that.I guess the good news is that even without retry, the new implementation has only rarely failed. 😄
TODOs:
Release note: