add willie-yao to reviewers list #3208
Conversation
k8s-ci-robot
added
release-note-none
|
/hold for consensus |
k8s-ci-robot
added
the
do-not-merge/hold
There was a problem hiding this comment.
/lgtm
Yes, please. @willie-yao does great work and it would be a real boost to the project to formalize him as a reviewer. Thanks @willie-yao!
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b22101fc68ff4a9f7dea9fe2325c16c9da9187cf
|
k8s-ci-robot
assigned CecileRobertMichon, devigned, Jont828, jsturtevant, marosset, nojnhuh and sonasingh46
|
+1 |
|
/lgtm Great to see @willie-yao progressing to reviewer, thank you for all your contributions so far! |
|
+1, @willie-yao has definitely gotten into (and through) the weeds on many occasions. Great work! |
|
/retest |
|
+1 Let’s go, Willie! Well earned! |
|
+1 @willie-yao has been nailing it. Thank you. Go, go, go! |
|
Should start a lazy consensus on this? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@CecileRobertMichon lazy consensus on this is now 4 days old. Should we expire EOD today? (By the way in the spirit of lazy consensus everything you lazily ask defaults to yes) |
|
let's expire at office hours tomorrow |
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR will add @willie-yao as a CAPZ reviewer.
According to the requirements defined here:
https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-1
@willie-yao has been a member of the Kubernetes org since 22 November 2022:
was the primary reviewer of these recent 5 PRs:
in addition was the author of 27 merged PRs:
has been a contributing reviewer of 15 PRs overall:
Willie's reviews are especially valuable as he's been a consistent contributor to the codebase in various areas, including several significant PRs (5 size XL or larger), acquiring lots of domain expertise along the way. Thank you Willie!
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: