🐛 ROSA: Fix rosaNetwork set availabilityZones

[serngawy]

Fix issue #5715

What type of PR is this?
bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Fix create ROSANetwork with specifying the availabilityZones

[serngawy]

/cherry-pick main

[k8s-infra-cherrypick-robot]

@serngawy: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

@serngawy We normally merge it on main first and then backport it.
Would you be able to open on there? TY

[AndiDog]

/lgtm

(but please fix the target branch as mentioned above)

[AndiDog]

This looks like a breaking change – leaving that to you to decide

[serngawy]

actually this is fixing the bug, the CF template expecting AZ1, AZ2, ...etc AND we were passing AZ0 here

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1698879cda4144b79be4af03b77326ede4f2fa6b

[serngawy]

@serngawy We normally merge it on main first and then backport it. Would you be able to open on there? TY

sure, I tried to set target to main but rebase failed (most likely cherry-pick will fail), so I did rebase locally and pushed PR to main here #5721

[AndiDog]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AndiDog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@serngawy: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api-provider-aws#main from head k8s-infra-cherrypick-robot:cherry-pick-5718-to-main: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:main and k8s-infra-cherrypick-robot:cherry-pick-5718-to-main"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.