🐛 Launchtemplate needs to be updated if spot options are changed #5496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/test pull-cluster-api-provider-aws-e2e |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d778b6d36ce012772b2bb23779e7a386fca21354
|
fiunchinho
force-pushed
the
fix-launchtemplate-needs-update
branch
from
99f00ed to
4a57ee5
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
fiunchinho
force-pushed
the
fix-launchtemplate-needs-update
branch
2 times, most recently
from
6f3953d to
e0d5e11
Compare
fiunchinho
force-pushed
the
fix-launchtemplate-needs-update
branch
from
e0d5e11 to
99c1047
Compare
|
/test pull-cluster-api-provider-aws-e2e |
|
@alexander-demicev After testing the changes in our management cluster, I needed to do more changes to make this work. PTAL, thanks. |
|
/assign @richardcase @nrb |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 02415027f639a72267bbf198afc6bf2cbaa01b86
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the spot instances options are changed, we want to update the launch template so that the changes take effect.
Special notes for your reviewer:
I've changed the unit tests for the
LaunchTemplateNeedsUpdatefunction, because some cases were passing by pure chance. Basically these security groups are always added to the incomingAWSLaunchTemplateSo if the existing
AWSLaunchTemplatethat we use in the tests don't have these security groups, the function will always return true. Tests like the one testing changes to theIamInstanceProfilefield were passing because of the different security groups, rather than the change on theIamInstanceProfilefield.Checklist:
Release note: