-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure cloud-init to use ec2-user instead of centos on Amazon Linux #541
Conversation
Hi @sfzylad. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With this changes I was able to bake an AMI and login as |
Does this get overwritten by package upgrades by any chance? |
i.e. is this marked properly as a config file in the RPM? |
The file belongs to the RPM and is marked as a config file: [root@ip-10-0-1-54 ~]# rpm -qf /etc/cloud/cloud.cfg
cloud-init-18.3+52.gc5f78957-1.el7.noarch
[root@ip-10-0-1-54 ~]# rpm -qc cloud-init-18.3+52.gc5f78957-1.el7.noarch |grep cloud.cfg
/etc/cloud/cloud.cfg |
/ok-to-test |
/approve @randomvariable or @chuckha want to give final lgtm? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, sfzylad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# max_wait: 10 # (defaults to 120 seconds) | ||
|
||
# The modules that run in the 'init' stage | ||
cloud_init_modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all of these modules (and config_modules and final_modules)? Like salt-minion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think this is fine, since this file is directly from the cloud-init package and tweaked for the correct default user.
/lgtm In summary, this takes the standard config file out of the package that we were already installing and customizes it slightly so that it works on amazon-linux. The file is marked as a config file so upgrades will not overwrite the customization. |
PCP-124: Adding tags to AWS Network Interfaces
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #536
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: