Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ROSA: Fix version gate Ack for rosa hcp y-stream version upgrade #5166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/rosa/versions.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,23 @@ func ScheduleControlPlaneUpgrade(client *ocm.Client, cluster *cmv1.Cluster, vers
ScheduleType(cmv1.ScheduleTypeManual).
Version(version).
NextRun(nextRun).
EnableMinorVersionUpgrades(true).
Build()
if err != nil {
return nil, err
}

versionGates, err := client.GetMissingGateAgreementsHypershift(cluster.ID(), upgradePolicy)
if err != nil {
return nil, err
}

for id := range versionGates {
if err = client.AckVersionGate(cluster.ID(), versionGates[id].ID()); err != nil {
return nil, err
}
}

return client.ScheduleHypershiftControlPlaneUpgrade(cluster.ID(), upgradePolicy)
}

Expand All @@ -64,6 +77,7 @@ func ScheduleNodePoolUpgrade(client *ocm.Client, clusterID string, nodePool *cmv
ScheduleType(cmv1.ScheduleTypeManual).
Version(version).
NextRun(nextRun).
EnableMinorVersionUpgrades(true).
Build()
if err != nil {
return nil, err
Expand Down