✨ Remove sorting from instance keys when creating input tag specifications

[AlexVulaj]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently when generating input tag specifications, we sort all of the keys from the given *infrav1.Instance before appending them to input.TagSpecifications. From the comments, this is done "for tests to work". This currently comes at the performance cost of iterating through all of the tags to grab the keys, and then sorting them before iterating the list again to add them to our input.

By utilizing a custom gomock.Matcher, we can transfer that performance hit from our production code to our tests.

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

NONE

[k8s-ci-robot]

Welcome @AlexVulaj!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @AlexVulaj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

/ok-to-test

[iamkirkbater]

It's been a while since I've been deep into coding world, but just saw two things that immediately stood out to me as potential problems down the road. Not sure if the one about the for loop matters in this case because I don't specifically remember the conditions in which it's "bad" but figured I'd bring it up.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[r4f4]

/lgtm

[k8s-ci-robot]

@r4f4: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AlexVulaj]

I rebased my PR today - not sure I understand the error in the PR Verify check but if anyone can point out what I need to do it'd be appreciated, thanks!

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.