Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add support for additionalControlPlaneIngressRule on AWSManaged… #4783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add support for additionalControlPlaneIngressRule on AWSManaged… #4783

wants to merge 1 commit into from

Conversation

fad3t
Copy link
Contributor

@fad3t fad3t commented Feb 9, 2024 •
edited by Ankitasw
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This change adds support for additional control plane ingress rules when using the AWS managed control plane.
Currently, the additional security group gets created but is empty, even if additional ingress rules are specified in the managed control plane specs.

Fixes #4788

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

feat: add support for additionalControlPlaneIngressRules in AWSManagedControlPlane

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 9, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @fad3t!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @fad3t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fad3t fad3t changed the title feat: add support for additionalControlPlaneIngressRule on AWSManaged… ✨ Add support for additionalControlPlaneIngressRule on AWSManaged… Feb 9, 2024
@fad3t fad3t mentioned this pull request Feb 13, 2024
Open
@fad3t fad3t marked this pull request as draft February 13, 2024 10:42
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@fad3t fad3t marked this pull request as ready for review February 13, 2024 13:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@fad3t
Copy link
Contributor Author

fad3t commented Feb 25, 2024

Hey there 👋 anything I can do to push this forward? Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@fad3t fad3t force-pushed the feat-managed-additional-sg branch from 0b0d722 to eb671ff Compare March 7, 2024 07:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@Ankitasw Ankitasw added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2024
@nrb
Copy link
Contributor

nrb commented Apr 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2024
@fad3t
Copy link
Contributor Author

fad3t commented Jul 25, 2024

/retest

@robinkb
Copy link

robinkb commented Sep 24, 2024

I am interested in getting this feature merged. Not sure how to clean up from the failed rebase, though.

@dntosas
Copy link
Contributor

dntosas commented Oct 8, 2024

any news in here? @Ankitasw @fad3t

@dntosas
Copy link
Contributor

dntosas commented Oct 8, 2024

@fad3t would be possible to transfer the branch without the rebase ?

@fad3t fad3t force-pushed the feat-managed-additional-sg branch from 326d7a5 to eb671ff Compare October 8, 2024 07:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2024
@fad3t fad3t force-pushed the feat-managed-additional-sg branch from 89d1bb6 to eb671ff Compare October 8, 2024 07:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2024
@fad3t
Copy link
Contributor Author

fad3t commented Oct 8, 2024

@fad3t would be possible to transfer the branch without the rebase ?

Sure, what exactly do you want me to do?
BTW I removed all the rebase commits, so now this PR is only the 3 commits I initially prepared. If somebody feels like rebasing it for me, go ahead.

@dntosas dntosas mentioned this pull request Oct 9, 2024
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 9, 2024
@fad3t fad3t force-pushed the feat-managed-additional-sg branch from a3b7ee8 to 4232d46 Compare October 9, 2024 07:21
@richardcase
Copy link
Member

This will probably fail (due to AMI issue) but worth a try:

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member

When the e2e passes/fails lets just check the error and then unhold and get it merged.

/hold

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@fad3t
Copy link
Contributor Author

fad3t commented Oct 9, 2024

Are we good @richardcase ?

@dntosas
Copy link
Contributor

dntosas commented Oct 10, 2024

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot
Copy link
Contributor

@fad3t: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e 4232d46 link false /test pull-cluster-api-provider-aws-e2e
pull-cluster-api-provider-aws-e2e-eks 4232d46 link false /test pull-cluster-api-provider-aws-e2e-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-dyer-sp ryan-dyer-sp ryan-dyer-sp left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@luthermonson luthermonson Awaiting requested review from luthermonson

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@nrb nrb Awaiting requested review from nrb

Assignees

@richardcase richardcase

@nrb nrb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for additionalControlPlaneIngressRules in AWSManagedControlPlane