Add ability to use NLBs as control plane load-balancers

[Skarlso]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3088

Special notes for your reviewer:

TODOs:

• IPv6 - res.Attributes["ipv6.deny_all_igw_traffic"] and the ipType for the NLB
• Hosts re-write
• SSL
• Bunch of tests
• Update status with an NLB if present
• Documentation
• Samples configuration
• Deregister nodes when they are being deleted and they are part of NLB

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[Skarlso]

I just learned that you couldn't attach security groups to network load balancers.

[Skarlso]

Almost there. :D It can't create the target group which I don't understand at all why because the error is super unhelpful.

name="test-aws-cluster" reconcileID=35f899c1-3e15-484e-b030-6870452713c5 cluster="default/test-aws-cluster" group=<
	{
	  HealthCheckEnabled: true,
	  HealthCheckIntervalSeconds: 10000000000,
	  HealthCheckProtocol: "TCP",
	  HealthCheckTimeoutSeconds: 5000000000,
	  HealthyThresholdCount: 5,
	  Name: "apiserver-target",
	  Port: 6443,
	  Protocol: "TCP",
	  VpcId: "vpc-064d130f24068f471"
	}
 > listener={Protocol:TCP Port:6443 TargetGroup:{Name:0xc0011018d0 Port:0xc000b59520 Protocol:TCP VpcID:0xc0011018e0 HealthCheck:0xc0004c0150}}
E1101 20:46:18.337089     986 logger.go:84] "failed to create LB" err=<
	failed to create target group for load balancer: MalformedInput: 
		status code: 400, request id: ced119e5-11d9-4109-a1bf-b98f1554f126
 > controller="awscluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSCluster" aWSCluster="default/test-aws-cluster" namespace="default" name="test-aws-cluster" reconcileID=35f899c1-3e15-484e-b030-6870452713c5 cluster="default/test-aws-cluster"
E1101 20:46:18.337178     986 logger.go:84] "failed to reconcile load balancer" err=<
	failed to create target group for load balancer: MalformedInput: 
		status code: 400, request id: ced119e5-11d9-4109-a1bf-b98f1554f126

It looks okay to me. :D

[Skarlso]

IT WORKED! I have a working NLB! :D

It was the health check, apparently; I'm not sure why yet.

[Skarlso]

BOOM!

[Skarlso]

IT'S ALIVE

[Ankitasw]

Minor comments.
Otherwise LGTM, great work 🎉

[Ankitasw]

/lgtm

[Ankitasw]

cc @richardcase for final approval

[richardcase]

Do we want to expose the V2 part in our API to the user?

[richardcase]

Will there be confusion with listener and v2Listeners? Guessing this could be coverted in the docs (which i haven't got to yet ;) )

[Skarlso]

Good question! I only exposed it because the other one was exposed as well. Do you think it's usually not needed at all? I'm happy not to include this at all. It doesn't seem like users would define extra listeners.

That said, there might be an option to add an extra health check or something... 🤔

[Skarlso]

In any case, I renamed it. :)

[richardcase]

And i should've said, looks great @Skarlso....excellent work. Most of my comments are nits.

[johannesfrey]

Also, totally forgot so say awesome work @Skarlso ❤️ 🙂. Only some nits.

[Skarlso]

Thank you, all! :)

[Skarlso]

/test pull-cluster-api-provider-aws-e2e-eks

[Ankitasw]

/lgtm

[richardcase]

/lgtm

[richardcase]

I meant:

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment