Adding apidiff target to the Makefile

[meghanajangi]

Signed-off-by: Meghana Jangi mjangi@vmware.com

What type of PR is this?

What this PR does / why we need it:
Adds a Make target that takes a diff on API changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3169

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Add apidiff Make target

[k8s-ci-robot]

@meghanajangi: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @meghanajangi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ankitasw]

/ok-to-test

[Ankitasw]

@meghanajangi have you locally tested make apidiff. It gives error for me.

cd hack/tools && go build -tags=tools -o bin/go-apidiff github.com/joelanford/go-apidiff
go: downloading golang.org/x/exp v0.0.0-20211029160041-3396431c207b
hack/tools/bin/go-apidiff 33c9ef9 --print-compatible
git tree is dirty
make: *** [apidiff] Error 2

[meghanajangi]

@meghanajangi have you locally tested make apidiff. It gives error for me.

cd hack/tools && go build -tags=tools -o bin/go-apidiff github.com/joelanford/go-apidiff
go: downloading golang.org/x/exp v0.0.0-20211029160041-3396431c207b
hack/tools/bin/go-apidiff 33c9ef9 --print-compatible
git tree is dirty
make: *** [apidiff] Error 2

I have fixed the git tree issue now, can you please check again?

[Ankitasw]

/lgtm

[sedefsavas]

I think we will need to update the apidiff script to use the new make target instead of calling apidiff binary directly.
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/scripts/ci-apidiff.sh

After doing the changes, it will be great if you can confirm that the script is working and then we will merge the test-infra PR.

[sedefsavas]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment