Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix minor typo in "ssm put-parameter" command #237

Merged
merged 1 commit into from
Oct 12, 2018
Merged

docs: fix minor typo in "ssm put-parameter" command #237

merged 1 commit into from
Oct 12, 2018

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Oct 12, 2018

What this PR does / why we need it:

Fix minor typo.

Release note:

NONE

@gyuho
docs: fix minor typo in "ssm put-parameter" command
89a9891 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2018
@randomvariable
Copy link
Member

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2018
@randomvariable
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 12, 2018
detiber
detiber reviewed Oct 12, 2018
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, gyuho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit da98511 into kubernetes-sigs:master Oct 12, 2018
@gyuho gyuho deleted the typo branch October 12, 2018 19:57
@gyuho gyuho mentioned this pull request Oct 12, 2018
Closed
6 tasks
csrwng pushed a commit to csrwng/cluster-api-provider-aws that referenced this pull request Jul 20, 2019
@openshift-merge-robot
Merge pull request kubernetes-sigs#237 from mgugino-upstream-stage/ve…
7a53d36 
…ndor-cluster-api

Update vendor cluster-api and kubernetes-drain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@chuckha chuckha Awaiting requested review from chuckha

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @randomvariable @k8s-ci-robot @detiber