Skip to content

🐛 Update existing conditions to have a non-empty Reason field #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+23 −0
Merged

🐛 Update existing conditions to have a non-empty Reason field #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions internal/controller/genericprovider_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ func (r *GenericProviderReconciler) Reconcile(ctx context.Context, req reconcile
}

func patchProvider(ctx context.Context, provider operatorv1.GenericProvider, patchHelper *patch.Helper, options ...patch.Option) error {
// Fix existing conditions to ensure they have required Reason field
normalizeExistingConditions(provider)

conds := []string{
operatorv1.PreflightCheckCondition,
operatorv1.ProviderInstalledCondition,
Expand All @@ -203,6 +206,26 @@ func patchProvider(ctx context.Context, provider operatorv1.GenericProvider, pat
return patchHelper.Patch(ctx, provider, options...)
}

// normalizeExistingConditions ensures all existing conditions have required Reason field.
func normalizeExistingConditions(provider operatorv1.GenericProvider) {
conditions := provider.GetConditions()
modified := false

for i := range conditions {
condition := &conditions[i]

// Set reason to condition type if empty
if condition.Reason == "" {
condition.Reason = condition.Type
modified = true
}
}

if modified {
provider.SetConditions(conditions)
}
}

func (r *GenericProviderReconciler) reconcile(ctx context.Context) (*Result, error) {
var res Result

Expand Down