-
Notifications
You must be signed in to change notification settings - Fork 108
📖 add notes on building oci artifacts as well as using plain http #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 add notes on building oci artifacts as well as using plain http #909
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @amsuggs37. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8c370b3af2b9b3509d13aeaa28605e3626ad92db
|
What this PR does / why we need it:
This PR adds a few notes to the air-gapped-environment documentation that add clarity to properly configuring the oci artifacts to be fetched.
I was recently setting up an air-gapped installation of the operator and installing providers to my cluster following these docs and found that it was ambiguous on how to configure the artifacts. I was under the impression that the artifacts need only to be in an oci compliant registry rather than the oci layout. As such, I was building simple docker images that were not in oci layout and the operator could not find the metadata/components files for any given provider despite successfully fetching the artifact from the oci registry.
The added notes include a link to the local plugin docs describing how to properly build and publish provider artifacts such that the operator can successfully fetch the artifact and then also extract the metadata/components files. I also add a note on how to fetch artifacts using plain http. As I was in development, my oci registry was a local zarf registry and I was accessing it over http. Using a fetchConfig.oci without the http:// prefix resulted in the operator erroring with a message stating that the server returned an http status to an https client. I had to dig through the controller source code to find out how to properly instruct the operator to pull the artifacts via http.