🌱 support Git release URLs as source for plugin ConfigMap #894
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
feat-support-gh-releases-in-plugin
branch
from
a2b7bf8 to
c4aee92
Compare
|
thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
There are some strange failures in E2E that we're troubleshooting. It's failed in separate executions unrelated to these changes: https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/periodic-cluster-api-operator-e2e-main |
|
/test pull-cluster-api-operator-e2e-main I am retriggering to see if it is fixed now, since it is passing in other PR #880 |
|
/test pull-cluster-api-operator-e2e-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9dae3de3a038fbbc2beb281641f7cda063826739
|
|
/cherry-pick release-0.23 |
|
@salasberryfin: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
|
@salasberryfin: new pull request created: #895 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retitle 🌱 support Git release URLs as source for plugin ConfigMap |
k8s-ci-robot
changed the title
6 participants
What this PR does / why we need it:
Operator plugin provides a solution to create a
ConfigMapwith the contents of a resource manifest fetched from an OCI registry. This PR adds support for using GitHub/GitLab releases as source.The existing
-uparameter maintains the current behavior if an OCI registry is passed but will first validate if the provided URL contains a GitHub/GitLab host and, if so, will retrieve the manifest file from the full release URL.If using this new alternative source, the full URL must be set, e.g.
-u https://github.com/kubernetes-sigs/cluster-api/releases/v1.10.5/core-components.yaml, including schema, version, and components file. In this case, the provider version is always included in the URL.New examples are added to the plugin's executable and the CAPI Operator book.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #