✨ Expose internal controllers #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds existing internal controller implementations into the `controller/alias.go` file. This is an initial step towards addressing issue kubernetes-sigs#798, which aims to provide a public API for CAPI Operator providers. The current controller implementation is internal, and this change is a step towards organizing the internal structure, potentially in preparation for exposing parts of it or providing extension points for custom providers. Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/L
Introduce a custom `Result` type for reconciliation phases to provide more granular control over the reconciliation flow, including a `Completed` flag. Update phase functions and the phase runner to use the new `*Result` return type instead of `ctrl.Result`. This allows phases to signal completion explicitly, improving the logic for handling sequential phases. Modify the generic provider controller and related components (manifests downloader, phases) to align with the new `Result` type and phase function signatures. Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Implement a phase-based framework for reconciling generic providers. This refactors the main reconciliation loop into a sequence of distinct, ordered phases (e.g., download, install, delete). Introduce `PhaseFn` and `phaseReconciler` types to manage phase execution. Move existing reconciliation logic into dedicated phase functions. Update the external `controller` package to epose aliases pointing to the refactored internal types for external import. Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
enable it for all non core provider types (Infrastructure, Bootstrap, ControlPlane, Addon, IPAM, RuntimeExtension). Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
expose-internal-controllers
branch
from
4597b2d to
75426a2
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
expose-internal-controllers
branch
from
3b07f31 to
0fe1d45
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 068beb75a84081ed77bdced6545d16cd8f79b540
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors the generic provider reconciliation logic to expose internal controllers and phases through the
controller/alias.gofile. This change allows external users to construct and interact with the core controller logic outside the operator pod.Resulttype to avoid controller-runtime dependency on import.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #798