Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add e2e tests for IPAM provider to Cluster API Operator Helm chart #734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Add e2e tests for IPAM provider to Cluster API Operator Helm chart #734

wants to merge 1 commit into from

Conversation

rgeraskin
Copy link
Contributor

What this PR does / why we need it:

This PR brings e2e tests for the IPAM provider into the Cluster API Operator Helm chart, on top of what was done in PR #688.

  • Update core-conditions.yaml to include IPAM provider in deployment conditions
  • Add IPAM provider test cases in helm_test.go
  • Create new / update test resource files for IPAM provider scenarios

@rgeraskin
test: add Helm chart e2e tests for IPAM provider
2f73b05 
- Update core-conditions.yaml to include IPAM provider in deployment conditions
- Add IPAM provider test cases in helm_test.go
- Create new / update test resource files for IPAM provider scenarios
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rgeraskin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 2f73b05
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67be5f60785f120008561700
😎 Deploy Preview https://deploy-preview-734--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@furkatgofurov7
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2025
furkatgofurov7
furkatgofurov7 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@rgeraskin
Copy link
Contributor Author

@furkatgofurov7 this PR still missing lgtm label afaik. Should I do anything to kick the process off?

@furkatgofurov7
Copy link
Member

@rgeraskin hey, no. It is just missing lgtm label from other maintainers, but already has approve.

cc @alexander-demicev @Danil-Grigorev @Fedosin PTAL

mjura
mjura approved these changes Mar 10, 2025
View reviewed changes
Copy link

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjura mjura mjura approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgeraskin @k8s-ci-robot @furkatgofurov7 @mjura