Skip to content

📖 Inital Netlify book structure version of operator #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

📖 Inital Netlify book structure version of operator #435

merged 1 commit into from
Mar 4, 2024

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Feb 26, 2024 •
edited
Loading

What this PR does / why we need it:

This commit puts together the skeleton of Netlify book structure and
by no means a final one and subject to change and iterations. Builds on top of #433 and will be rebased once it is merged.

To try it, run from docs/book folder:

  1. make build
  2. make serve
  3. navigate to http://localhost:3000 to see the local version of the book deployed
Screenshot 2024-02-26 at 11 30 27

Related to: #329

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 26, 2024
@furkatgofurov7 furkatgofurov7 force-pushed the operator-book-structure branch 4 times, most recently from eef8e0d to 37777c0 Compare February 26, 2024 12:37
@furkatgofurov7
Copy link
Member Author

#423 is merged and rebased this PR on top of it now, next waiting for Netlify site and DNS issues to be resolved before we take this in.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
@furkatgofurov7
Initial version of Operator book structure
58ec470 
This commit puts together skeleton of Netlify book structure and
by no means a final one and subject to change and iterations

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 force-pushed the operator-book-structure branch from 37777c0 to 58ec470 Compare February 26, 2024 13:28
@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Feb 26, 2024 •
edited
Loading

/hold cancel

Netlify site and DNS records are all setup and book is live now: https://cluster-api-operator.sigs.k8s.io/

so, this is ready for review.

/cc @Fedosin @alexander-demicev

@k8s-ci-robot k8s-ci-robot requested a review from Fedosin February 26, 2024 17:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
Fedosin
Fedosin approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you rock!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@Danil-Grigorev
Copy link
Member

@furkatgofurov7 Can you please follow previous naming convention from initial book structure? This way it does not need to update SUMMARY.md, it is done automatically.

Fedosin
Fedosin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0eead708b295c50a6f94480c4e6bba0de9c5848

@k8s-ci-robot k8s-ci-robot merged commit 006442f into kubernetes-sigs:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Fedosin approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@furkatgofurov7 @k8s-ci-robot @Danil-Grigorev @Fedosin