🐛 Prevent propagation of OwnerReferences from provider manifests

[Danil-Grigorev]

What this PR does / why we need it:

Healthcheck implementation expects deployment availability and an ownership reference pointing to the owner resource, to mark the provider as ready. However if the provider manifest is owned by some other resource, the second ownership reference appears on the deployment too, which is unexpected.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #350

[Fedosin]

Hey! Probably we need to fix this issue here: https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/internal/controller/healthcheck/healthcheck_controller.go#L71-L76

Probably it's okay to have multiple owners for deployments, but there should be only one Provider owner. So, if we have just one owner, we need to add a check that this owner is a Prover CR. Otherwise we have to iterate over the owners and find the Provider one (or return an error if nothing found)

[Danil-Grigorev]

Hey! Probably we need to fix this issue here: https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/internal/controller/healthcheck/healthcheck_controller.go#L71-L76

Probably it's okay to have multiple owners for deployments, but there should be only one Provider owner. So, if we have just one owner, we need to add a check that this owner is a Prover CR. Otherwise we have to iterate over the owners and find the Provider one (or return an error if nothing found)

I tried to refactor the reconciler which will fix this issue. Here is a separate PR for that: #354

[Fedosin]

/retest

[Fedosin]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Fedosin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Fedosin]

/retest

[Fedosin]

The patch is good, thanks for fixing the bug!

[Fedosin]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ac84d968ffbb0634713121d2b994f01a0288d0ad