Skip to content

✨ Add workflow for a book publishing job #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

✨ Add workflow for a book publishing job #331

merged 1 commit into from
Nov 22, 2023

Conversation

Danil-Grigorev
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #330

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2023
alexander-demicev
alexander-demicev approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
Fedosin
Fedosin approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

awesome work! thanks Danil

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2a02977e10a7ac9ca62df4b87f49efd0e0cd7ec1

furkatgofurov7
furkatgofurov7 reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Danil-Grigorev for the PR!

docs/book/src/01_intro.md
@@ -0,0 +1,8 @@
# Cluster API Operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name could be just introduction.md without numbering, but should be fine as a initial base for the book

/lgtm

Copy link
Member Author

@Danil-Grigorev Danil-Grigorev Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure is using https://lib.rs/crates/mdbook-fs-summary - it might be easier to handle summary generation then doing this manually, and less chances that it will leave broken links. That's why it has 01_ in the front

@k8s-ci-robot k8s-ci-robot merged commit 5e66c7a into kubernetes-sigs:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@Fedosin Fedosin Fedosin approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@Fedosin Fedosin

@furkatgofurov7 furkatgofurov7

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement book structure

5 participants

@Danil-Grigorev @k8s-ci-robot @Fedosin @alexander-demicev @furkatgofurov7