✨ Add plugin skeleton #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Fedosin
force-pushed
the
plugin_skeleton
branch
from
fb745b5 to
eb94ca1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Fedosin
force-pushed
the
plugin_skeleton
branch
from
eb94ca1 to
1c00f8d
Compare
|
/hold cancel |
k8s-ci-robot
added
needs-rebase
Fedosin
force-pushed
the
plugin_skeleton
branch
from
1c00f8d to
e61edbd
Compare
k8s-ci-robot
added
needs-rebase
Currently operator doesn't support these types, but in the future we want to add it.
Fedosin
force-pushed
the
plugin_skeleton
branch
from
e61edbd to
823cb0d
Compare
k8s-ci-robot
removed
the
needs-rebase
Danil-Grigorev
approved these changes
Nov 21, 2023
| capioperator init --infrastructure=aws;vsphere | ||
| # Initialize a management cluster with a custom target namespace for the operator. | ||
| capioperator init --infrastructure aws --target-namespace foo`), |
There was a problem hiding this comment.
I think there should be options for passing full yaml manifests for these options too.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1eaed426b94f4e0b776840aaf6421397dca61a1e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a skeleton for our plugin. It defines command line interfaces that will be used to manage CAPI providers, and additionally implements some utils to simplify working with the cluster.
Added interfaces for the next operations:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #